[ 
https://issues.apache.org/jira/browse/BEAM-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858826#comment-15858826
 ] 

ASF GitHub Bot commented on BEAM-1429:
--------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/1942


> WindowFn assign should only have access to the element and timestamp
> --------------------------------------------------------------------
>
>                 Key: BEAM-1429
>                 URL: https://issues.apache.org/jira/browse/BEAM-1429
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py
>    Affects Versions: Not applicable
>            Reporter: Sourabh Bajaj
>            Assignee: Sourabh Bajaj
>            Priority: Minor
>
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/transforms/window.py#L97
>  does not really use access to multiple windows at the same time. 
> Also as we move to the NewDoFn we have moved away from accessing the 
> windowSet together. Change the function here to only take the element and 
> timestamp as the input. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to