GitHub user kennknowles opened a pull request: https://github.com/apache/beam/pull/1988
[BEAM-1195, BEAM-115] Add full-fidelity conversion to/from Java SDK triggers and Runner API protos Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [x] Make sure the PR title is formatted like: `[BEAM-<Jira issue #>] Description of pull request` - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [x] Replace `<Jira issue #>` in the title with the actual Jira issue number, if there is one. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- This PR has somewhat independent commits that make sense to review together: 1. Alter the Java SDK's trigger classes to have the necessary functionality to reconstruct easily from a serialized form. 2. Simplify some inheritances relationship in the Java SDK that were actually incorrect. 3. Flesh out the Runner API proto to include all the needed bits to serialize triggers fully. 4. Actually serialize triggers and their inverse; test the round trip. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kennknowles/beam trigger-proto Alternatively you can review and apply these changes as the patch at: https://github.com/apache/beam/pull/1988.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1988 ---- commit 46df18fc2a0de22ced7dbeaf47508a5bdd9c1493 Author: Kenneth Knowles <k...@google.com> Date: 2017-02-12T23:03:48Z Reify delay and alignment in AfterProcessingTime transform commit 8d62655b75377be8d0a6be2803abf25882d36663 Author: Kenneth Knowles <k...@google.com> Date: 2017-02-12T00:47:15Z Add runner API config to poms commit 16d5704ec5f6a0db8c678c69f2acc122aa1e0b4a Author: Kenneth Knowles <k...@google.com> Date: 2017-02-12T00:48:05Z Fix typo in runner API generated Java class commit 412145654af5f126776913fcc99595a729f10967 Author: Kenneth Knowles <k...@google.com> Date: 2017-02-12T01:26:56Z Add neglected ElementCount trigger to runner API proto commit 0b222ed0aa653faf1d3cd39873f2ff845016f2f8 Author: Kenneth Knowles <k...@google.com> Date: 2017-02-12T01:32:21Z Add TimeDomain to runner API protos commit 1e669eecaadadb1e8cbf5b031aff613efe30c0db Author: Kenneth Knowles <k...@google.com> Date: 2017-02-12T01:38:01Z Flesh out AfterProcessingTime in runner API commit 6954b4c539568b463aa602e012fa5aad2309a741 Author: Kenneth Knowles <k...@google.com> Date: 2017-02-12T23:53:17Z Upgrade Java triggers to support runner API deserialization commit 3100790d33dfa741c24fd62002cc62b17b142342 Author: Kenneth Knowles <k...@google.com> Date: 2017-02-12T01:50:27Z Add conversion to/from Java SDK trigger to runner API proto commit 69d0957d1109125294be5f057643684ea005dd06 Author: Kenneth Knowles <k...@google.com> Date: 2017-02-13T04:11:59Z fixup! Reify delay and alignment in AfterProcessingTime transform ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---