[
https://issues.apache.org/jira/browse/BEAM-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15863982#comment-15863982
]
ASF GitHub Bot commented on BEAM-1469:
--------------------------------------
GitHub user sb2nov opened a pull request:
https://github.com/apache/beam/pull/1992
[BEAM-1469] Increase the bounds on the test to reduce flakiness
R: @aaltay PTAL
Surprisingly I ran the test 100 times in a loop and didn't see a flake
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sb2nov/beam BEAM-1469-fix-flaky-pi-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/1992.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1992
----
commit 430ba5f56abff562effc000d1b0fc93973b2e3e0
Author: Sourabh Bajaj <[email protected]>
Date: 2017-02-13T16:59:59Z
Increase the bounds on the test to reduce flakiness
----
> Estimate Pi test is flaky
> -------------------------
>
> Key: BEAM-1469
> URL: https://issues.apache.org/jira/browse/BEAM-1469
> Project: Beam
> Issue Type: Bug
> Components: sdk-py
> Reporter: Ahmet Altay
> Assignee: Sourabh Bajaj
> Priority: Minor
>
> I get this error sometimes:
> DataflowAssertException: Failed assert: 3.150432 not in [3.130000, 3.150000]
> [while running 'assert_that/Match']
> root: WARNING: A task failed with exception.
> Failed assert: 3.150432 not in [3.130000, 3.150000] [while running
> 'assert_that/Match']
> This is probably related to the reduced trial size, We can relax the
> upper/lower bounds a little bit.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
