[
https://issues.apache.org/jira/browse/BEAM-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15863990#comment-15863990
]
ASF GitHub Bot commented on BEAM-1461:
--------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/1993
[BEAM-1461] Make PrepareForProcessing Final, Deprecated
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
This is only used by aggregators; Users should use @Setup or
@StartBundle instead.
Aggregators are set to be removed in
[BEAM-775](https://issues.apache.org/jira/browse/BEAM-775)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam prepare_for_processing
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/1993.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1993
----
commit fda5f1a39a9214d7dc9cc6566c01715f367493b1
Author: Thomas Groh <[email protected]>
Date: 2017-02-13T17:03:32Z
Make PrepareForProcessing Final, Deprecated
This is only used by aggregators; Users should use @Setup or
@StartBundle instead.
----
> duplication with StartBundle and prepareForProcessing in DoFn
> -------------------------------------------------------------
>
> Key: BEAM-1461
> URL: https://issues.apache.org/jira/browse/BEAM-1461
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Xu Mingmin
> Assignee: Davor Bonaci
>
> There're one annotation `StartBundle`, and one public function
> `prepareForProcessing` in DoFn, which are called both before
> `ProcessElement`. It's confused which one should be implemented in a subclass.
> The call sequence seems as:
> prepareForProcessing -> StartBundle -> processElement
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
