[
https://issues.apache.org/jira/browse/BEAM-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864212#comment-15864212
]
ASF GitHub Bot commented on BEAM-1280:
--------------------------------------
GitHub user sb2nov opened a pull request:
https://github.com/apache/beam/pull/1997
[BEAM-1280] Remove passing label from Combiners
R: @aaltay PTAL
After this only assert_that and AsSingleton etc for SideInputs take the
label as the argument. Rest should be gone.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sb2nov/beam
BEAM-1280-remove-label-from-combiners
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/1997.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1997
----
commit 5abfbf9300bada36adc7c55b0c2fe21a66215b67
Author: Sourabh Bajaj <[email protected]>
Date: 2017-02-13T16:48:18Z
Remove passing label from Combiners
----
> Remove label-first variants of PTransform constructors (use >> instead)
> -----------------------------------------------------------------------
>
> Key: BEAM-1280
> URL: https://issues.apache.org/jira/browse/BEAM-1280
> Project: Beam
> Issue Type: Bug
> Components: sdk-py
> Reporter: Ahmet Altay
> Assignee: Ahmet Altay
> Labels: sdk-consistency
>
> (Related in Java SDK: https://issues.apache.org/jira/browse/BEAM-370)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
