GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/2025
Move View Overrides out of the Dataflow Runner
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
No functionality change. This moves the view overrides to subclasses, which
should
hopefully make digging around in the Dataflow Runner somewhat easier.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam
view_overrides_out_of_dataflow_runner
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2025.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2025
----
commit 38f2d9d0275e00eb32fc30818b22beedc359f81b
Author: Thomas Groh <[email protected]>
Date: 2017-02-16T22:44:16Z
Move Batch View Overrides out of DataflowRunner
Although these are runner specific, they don't need to be in the runner
shim class.
commit 26dc9cfee3612adfffe9b3ae50f981fcb4d9d2ab
Author: Thomas Groh <[email protected]>
Date: 2017-02-16T22:58:52Z
Move Streaming View Overrides out of the DirectRunner
These overrides are implementation details of the runner and
runner-specific, but need not be within the Runner shim.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
