[
https://issues.apache.org/jira/browse/BEAM-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870972#comment-15870972
]
ASF GitHub Bot commented on BEAM-1504:
--------------------------------------
GitHub user vikkyrk opened a pull request:
https://github.com/apache/beam/pull/2028
[BEAM-1504] Parameterized tests for standard coders in Python SDK
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
`python setup.py test -s apache_beam.coders.standard_coders_test
...
test_standard_coder_0_bytes
(apache_beam.coders.standard_coders_test.StandardCodersTest) ... ok
test_standard_coder_1_bytes
(apache_beam.coders.standard_coders_test.StandardCodersTest) ... ok
test_standard_coder_2_varint
(apache_beam.coders.standard_coders_test.StandardCodersTest) ... ok
test_standard_coder_3_kv
(apache_beam.coders.standard_coders_test.StandardCodersTest) ... ok
test_standard_coder_4_kv
(apache_beam.coders.standard_coders_test.StandardCodersTest) ... ok
test_standard_coder_5_kv
(apache_beam.coders.standard_coders_test.StandardCodersTest) ... ok
test_standard_coder_6_intervalwindow
(apache_beam.coders.standard_coders_test.StandardCodersTest) ... ok
test_standard_coder_7_stream
(apache_beam.coders.standard_coders_test.StandardCodersTest) ... ok
test_standard_coder_8_stream
(apache_beam.coders.standard_coders_test.StandardCodersTest) ... ok
`
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vikkyrk/incubator-beam parameterized_tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2028.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2028
----
commit bb7e91b45f1d47642720e035ff549bfafe0bfbfe
Author: Vikas Kedigehalli <[email protected]>
Date: 2017-02-17T00:55:20Z
Parameterized tests for standard coders in Python SDK
----
> Python standard coders test doesn't run with setup test
> -------------------------------------------------------
>
> Key: BEAM-1504
> URL: https://issues.apache.org/jira/browse/BEAM-1504
> Project: Beam
> Issue Type: Bug
> Components: sdk-py
> Reporter: Vikas Kedigehalli
> Assignee: Vikas Kedigehalli
> Priority: Minor
>
> _python setup.py test_ does not run _standard_coders_test_. This is because
> dynamically generated tests are not visibile to _nose.collect_ plugin.
> Fix: use _nose-parameterized_ to create parameterized tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
