GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/2038
Improve check around accumulation mode
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
If multiple panes can ever be produced, accumulation mode must be
explicitly set, as there is currently no default accumulation mode. A
pipeline with allowed lateness and the default trigger can produce
multiple panes; as a result, accumulation mode must be set even if there
is no custom trigger if allowed lateness is specified.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam window_validation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2038.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2038
----
commit 4b17da76ad6ca5669e2021eefd029e65c0b0f169
Author: Thomas Groh <[email protected]>
Date: 2017-02-17T17:36:41Z
Improve check around accumulation mode
If multiple panes can ever be produced, accumulation mode must be
explicitly set, as there is currently no default accumulation mode. A
pipeline with allowed lateness and the default trigger can produce
multiple panes; as a result, accumulation mode must be set even if there
is no custom trigger if allowed lateness is specified.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
