GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/2065
[BEAM-115,BEAM-1348] Unify Runner API and Fn API coders
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
Just shares `Coder`. Its a hack - it is really crufty to have side-by-side
int and string registries. But coders need to be by-reference. Options, off the
top of my head:
1. Make everything keyed on int64 (distasteful for debugging, but not
horrid).
2. Make everything keyed on string.
3. Make Fn API and harness really embrace separate registries by type.
4. Write 3 lines of conversion code, since sharing this one trivial proto
has only unclear benefit, while avoiding a hard dependency is almost always a
win.
R: @dhalperi
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam fn-api-coders-only
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2065.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2065
----
commit 3d4aed8fa4dfc9f1c69bb39692e92c16b3002df6
Author: Kenneth Knowles <[email protected]>
Date: 2017-02-22T03:11:19Z
Unify Runner API and Fn API coders
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
