[
https://issues.apache.org/jira/browse/BEAM-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15877636#comment-15877636
]
ASF GitHub Bot commented on BEAM-307:
-------------------------------------
GitHub user XuMingmin opened a pull request:
https://github.com/apache/beam/pull/2069
BEAM-307: Upgrade/Test to Kafka 0.10
Run *KafkaIOTest.java* with `mvn test -Dkafka.clients.version=0.10.1.1`, or
`mvn test -Dkafka.clients.version=0.9.0.1` for either Kafka client version.
it can work with Kafka client 0.9 and 0.10 as:
1. SpEL can find this function, either input is List or Collection;
2. List extends Collection, so super.assign() could find either
assign(List) or assign(Collection).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/XuMingmin/beam master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2069.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2069
----
commit 9b0505ca5f244e28f8c83ca3f1037ae45e516791
Author: mingmxu <[email protected]>
Date: 2017-02-22T00:40:16Z
junit test for both Kafka 0.9 and 0.10
commit 07e207d845943c485e6280e1705cc7c153a2ef35
Author: mingmxu <[email protected]>
Date: 2017-02-22T07:10:45Z
add doc for how to test, and how it works
----
> Upgrade/Test to Kafka 0.10
> --------------------------
>
> Key: BEAM-307
> URL: https://issues.apache.org/jira/browse/BEAM-307
> Project: Beam
> Issue Type: Task
> Components: sdk-java-extensions
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Labels: backward-incompatible
>
> I gonna test at least that the KafkaIO works fine with Kafka 0.10 (I'm
> preparing new complete samples around that).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
