Ted Yu created BEAM-1568:
----------------------------

             Summary: Ineffective null check in IsmFormat#structuralValue
                 Key: BEAM-1568
                 URL: https://issues.apache.org/jira/browse/BEAM-1568
             Project: Beam
          Issue Type: Bug
          Components: runner-dataflow
            Reporter: Ted Yu
            Assignee: Davor Bonaci
            Priority: Minor


{code}
    public Object structuralValue(IsmRecord<V> record) throws Exception {
      checkState(record.getKeyComponents().size() == keyComponentCoders.size(),
          "Expected the number of key component coders %s "
          + "to match the number of key components %s.",
          keyComponentCoders.size(), record.getKeyComponents());

      if (record != null && consistentWithEquals()) {
{code}
record is de-referenced before the null check.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to