[ 
https://issues.apache.org/jira/browse/BEAM-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887531#comment-15887531
 ] 

ASF GitHub Bot commented on BEAM-1215:
--------------------------------------

Github user staslev closed the pull request at:

    https://github.com/apache/beam/pull/1695


> Assert over metrics sent to Graphite
> ------------------------------------
>
>                 Key: BEAM-1215
>                 URL: https://issues.apache.org/jira/browse/BEAM-1215
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-spark
>            Reporter: Stas Levin
>            Assignee: Stas Levin
>            Priority: Minor
>
> It would be great if we could have a way to assert over metrics sent by the 
> {{GraphiteSink}} to an actual Graphite server. 
> At the moment we have similar tests for the {{InMemoryMetrics}} sink, which 
> give a good level of confidence (that's why I've set this to Minor), but we 
> might be able to stretch things even further by capturing metrics sent by the 
> graphite reporter in the {{GraphiteSink}} using an in memory implementation 
> of a simple Graphite server.
> This could also be useful for other Beam components once they start reporting 
> to Graphite.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to