[
https://issues.apache.org/jira/browse/BEAM-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891145#comment-15891145
]
Ismaël Mejía commented on BEAM-1567:
------------------------------------
I just took a look and gave my comments, we will have to wait for Dan's final
word. Dan is quite efficient for this but I have seen that he is reviewing a
ton of stuff, so sorry if we make you wait.
For the next time the convention for reviewers at Beam is to mention them at
the PR, something like R: @iemejia, to call for the appropriate person as a
reviewer.
> hashStream should be closed in PackageUtil#createPackageAttributes()
> --------------------------------------------------------------------
>
> Key: BEAM-1567
> URL: https://issues.apache.org/jira/browse/BEAM-1567
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Ted Yu
> Priority: Minor
> Labels: newbie, starter
>
> Here is related code:
> {code}
> OutputStream hashStream = Funnels.asOutputStream(hasher);
> {code}
> hashStream should be closed upon return from the method
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
