[
https://issues.apache.org/jira/browse/BEAM-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894947#comment-15894947
]
ASF GitHub Bot commented on BEAM-1422:
--------------------------------------
GitHub user jkff opened a pull request:
https://github.com/apache/beam/pull/2153
[BEAM-1422] ParDo should comply with PTransform style guide
Backward-incompatible changes:
* Removes ParDo.Unbound and UnboundMulti (as a result, the only entry point
is ParDo.of(DoFn) - you can no longer specify ParDo.withSideInputs(...).of(fn)
and such)
* Renames ParDo.Bound to ParDo.SingleOutput and ParDo.BoundMulti to
ParDo.MultiOutput
R: @kennknowles
CC: @davorbonaci @dhalperi
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jkff/incubator-beam pardo-style
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2153.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2153
----
commit 11b3f133975f54f2a4f577b815e7a645aa007819
Author: Eugene Kirpichov <[email protected]>
Date: 2017-03-03T18:53:28Z
Removes ParDo.Unbound and UnboundMulti
commit 1e2369389faffa10a927c4ee8d3d0bfbff171e86
Author: Eugene Kirpichov <[email protected]>
Date: 2017-03-03T18:53:59Z
Removes accidentally left over class in test
commit 7f87e4413b97f982eb6590f6ad3aab8ba343e987
Author: Eugene Kirpichov <[email protected]>
Date: 2017-03-03T19:06:49Z
Renamed ParDo.Bound to ParDo.SingleOutput
commit 596beb96d052d545932842956ae93ca15ce9199d
Author: Eugene Kirpichov <[email protected]>
Date: 2017-03-03T19:13:10Z
Renamed ParDo.BoundMulti to ParDo.MultiOutput
----
> ParDo should comply with PTransform style guide
> -----------------------------------------------
>
> Key: BEAM-1422
> URL: https://issues.apache.org/jira/browse/BEAM-1422
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Eugene Kirpichov
> Assignee: Eugene Kirpichov
> Labels: backward-incompatible
>
> Suggested changes:
> - Get rid of ParDo.Unbound and UnboundMulti classes completely
> - Get rid of static methods such as withSideInputs/Outputs() - the only entry
> point should be via ParDo.of(). Respectively, get rid of non-static .of().
> - Rename ParDo.Bound and ParDo.BoundMulti respectively to simply ParDo and
> ParDoWithSideOutputs.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
