[
https://issues.apache.org/jira/browse/BEAM-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895052#comment-15895052
]
ASF GitHub Bot commented on BEAM-1620:
--------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/2154
[BEAM-1620] WIP: maven config for streaming RoS in Dataflow
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
@jasonkuster this is essentially an inlining of the configuration for
batch. Notes:
- I'd love to just provide `-D beamTestPipelineOptions=...` and have
things automatically just add `--streaming=true` and `--streaming=false` but
don't know that you can do that effectively in a POM.
- Setting `parallel=all` and `threadCount=4` I did manage to get a 429,
which surprised me. TBD why that happens; something is not blocking when it
should and/or leaking jobs.
CC @davorbonaci in case you have any vision for the right way for this
config to get into the project.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam streaming-RoS
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2154.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2154
----
commit 32650981f11167756d2ebe8fa5f6531e089970fa
Author: Kenneth Knowles <[email protected]>
Date: 2017-01-24T04:30:04Z
WIP: maven config for streaming RoS in Dataflow
----
> Add streaming Dataflow RunnableOnService coverage
> -------------------------------------------------
>
> Key: BEAM-1620
> URL: https://issues.apache.org/jira/browse/BEAM-1620
> Project: Beam
> Issue Type: Test
> Components: runner-dataflow, testing
> Reporter: Kenneth Knowles
> Assignee: Jason Kuster
>
> Currently, the runner validation test suite is not run on Dataflow in
> streaming mode. In fact, it should be able to run - all the functionality is
> in place. I think this is just a matter of maven + Jenkins + making sure not
> to leak a bunch of streaming jobs.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
