[ 
https://issues.apache.org/jira/browse/BEAM-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907610#comment-15907610
 ] 

ASF GitHub Bot commented on BEAM-923:
-------------------------------------

GitHub user iemejia opened a pull request:

    https://github.com/apache/beam/pull/2231

    [BEAM-923] Add localhost option for DatastoreIO (fix assignment issue)

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/iemejia/beam BEAM-923-localhost-for-datastore

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2231.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2231
    
----
commit eb7b5dd6c218f19f000119baf4ff330dac970748
Author: Ismaël Mejía <[email protected]>
Date:   2017-03-13T12:49:38Z

    [BEAM-923] Improve DatastoreV1 tests to detect wrong localhost assignment

commit 39ff12a24c2f03648f381aa4916efad7417f137b
Author: Ismaël Mejía <[email protected]>
Date:   2017-03-13T12:58:50Z

    [BEAM-923] Refactor DatastoreV1 Mutate to fix the issue with localhost 
assignment

----


> Add localhost option for DatastoreIO
> ------------------------------------
>
>                 Key: BEAM-923
>                 URL: https://issues.apache.org/jira/browse/BEAM-923
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-gcp
>            Reporter: Vikas Kedigehalli
>            Assignee: Vikas Kedigehalli
>            Priority: Minor
>
> Adding locahost option enables to connect to a Datastore emulator that is 
> running locally



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to