[
https://issues.apache.org/jira/browse/BEAM-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925055#comment-15925055
]
ASF GitHub Bot commented on BEAM-1260:
--------------------------------------
GitHub user jkff opened a pull request:
https://github.com/apache/beam/pull/2247
[BEAM-1260] Another shot at capturing PAssert site
This is a modified resubmit of https://github.com/apache/beam/pull/1753,
which was later rolled back in https://github.com/apache/beam/pull/1767 .
The current PR is basically the same, but I updated the Dataflow worker to
reduce nesting of wrapped exceptions, so now the error message goes through
(whereas previously it would lead to an exception so long that it was
truncated, and the original site was not visible).
R: @tgroh
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jkff/incubator-beam rollforward-passert-site
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2247.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2247
----
----
> PAssert should capture the assertion site
> -----------------------------------------
>
> Key: BEAM-1260
> URL: https://issues.apache.org/jira/browse/BEAM-1260
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Eugene Kirpichov
> Assignee: Eugene Kirpichov
> Fix For: 0.5.0
>
>
> When a PAssert assertion fails, it doesn't tell where the assertion
> (PAssert.that(blah)) call was made in code - only when the failure was
> detected, i.e. somewhere deep in worker code usually.
> It also doesn't allow specifying a message (unlike JUnit).
> This issue is about improving the way PAssert failures are reported.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
