GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/2256
[BEAM-1092] Rollback global shading of Guava
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
Revert PRs #2096 and #2249
PR #2096 has caused BigtableITs to fail, as of
https://builds.apache.org/job/beam_PostCommit_Java_MavenInstall/2906/
The `BigtableDataClient` has methods that return Guava types, e.g.
`sampleRowKeys` returns an `ImmutableList`, and we rewrite those calls to
reference the repackaged type, but we don't repackage the actual client
libraries; as a result when the JVM tries to find the
`sampleRowKeys(SampleRowKeysRequest) -> ImmutableList<SampleRowKeysResponse>`
it fails.
We can certainly not shade guava in the google-cloud-platform IOs module; I
believe it is also possible to repackage the appropriate Bigtable libraries to
ensure the return types of those methods are also repackaged. However,
`BigtableIO` uses classes that are defined in the `Bigtable` libraries, so we
would have to force our version on users.
@davorbonaci @aviemzur
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam no_repackage_gcp_io
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2256.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2256
----
commit 506a2cfa0b730d9b1ec8ec07223797c697b061f1
Author: Thomas Groh <[email protected]>
Date: 2017-03-15T22:28:45Z
Revert "Increment shade-plugin version back to 3.0.0"
This reverts commit 8f7c320846b598dc650a7b786182f7cecdd9c601.
commit dcfe32a14318d0daebad7319ba4143a25fc02be4
Author: Thomas Groh <[email protected]>
Date: 2017-03-15T22:28:47Z
Revert "[BEAM-1092] Replace hyphens in artifactId with dots in shading
relocations"
This reverts commit 2b55e0798f44e3fa644e7df1eaab43898ecf9c46.
commit 12873b9500c31b78d84ec6d52c0d9cf1a68edc39
Author: Thomas Groh <[email protected]>
Date: 2017-03-15T22:28:49Z
Revert "[BEAM-1092] Shade commonly used libraries (e.g. Guava) to avoid
class conflicts"
This reverts commit 03d78097ba0a2d55a9e8dcbaf11e0f8182f223c1.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
