[ 
https://issues.apache.org/jira/browse/BEAM-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15929513#comment-15929513
 ] 

ASF GitHub Bot commented on BEAM-1739:
--------------------------------------

GitHub user peihe opened a pull request:

    https://github.com/apache/beam/pull/2262

    [BEAM-1739] fix IndexOutOfBoundsException when index in Create overflows.

    Two fixes includes:
    1. Avoid integer overflow in Create.
    2. Stop calling advance() in UnboundedReadFromBoundedSource when all 
elements are consumed.
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/peihe/incubator-beam fix-out-of-bound

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2262.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2262
    
----
commit 8b43dcc010dee38dd23bdcb5d65d405ccc5dcd21
Author: Pei He <pei...@gmail.com>
Date:   2017-03-17T07:13:41Z

    [BEAM-1739] fix IndexOutOfBoundsException when index in Create overflows.

----


> Create failed in UnboundedReadFromBoundedSource
> -----------------------------------------------
>
>                 Key: BEAM-1739
>                 URL: https://issues.apache.org/jira/browse/BEAM-1739
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Pei He
>            Assignee: Pei He
>
> IndexOutOfBoundsException and index overflow when advanceImpl() is called 
> periodically in UnboundedReadFromBoundedSource.
> https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Create.java#L474



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to