[ 
https://issues.apache.org/jira/browse/BEAM-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932655#comment-15932655
 ] 

Ismaël Mejía commented on BEAM-1418:
------------------------------------

Hello, I don't know what do you think about this, but couldn't we also get rid 
of the 'Elements' suffix? Almost all the other core transforms don't use two 
words.

And then for the via method we can let it like it is, or even better replace it 
with elements to keep the previous context.

This will also eventually help to cover the case of evolving the transform to 
support Map.values() and Map.keys() as part of the same transform as discussed 
in BEAM-621.


> MapElements and FlatMapElements should comply with PTransform style guide
> -------------------------------------------------------------------------
>
>                 Key: BEAM-1418
>                 URL: https://issues.apache.org/jira/browse/BEAM-1418
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Eugene Kirpichov
>            Assignee: Davor Bonaci
>              Labels: backward-incompatible, starter
>             Fix For: First stable release
>
>
> Type structure of these classes can be improved by slightly changing the API:
> FlatMapElements.into(TypeDescriptor).via(as usual).
> Likewise for MapElements. This allows getting rid of the awkward 
> MissingOutputTypeDescriptor intermediate class.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to