[ 
https://issues.apache.org/jira/browse/BEAM-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938854#comment-15938854
 ] 

ASF GitHub Bot commented on BEAM-1780:
--------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/2298


> BigtableReader.splitIntoFraction should more carefully guard input
> ------------------------------------------------------------------
>
>                 Key: BEAM-1780
>                 URL: https://issues.apache.org/jira/browse/BEAM-1780
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-gcp
>            Reporter: Daniel Halperin
>            Assignee: Daniel Halperin
>             Fix For: First stable release
>
>
> The contract for {{splitIntoFraction}} is that it should only throw if the 
> reader is in an unknown, bad state. The proper way to reject invalid or 
> unsatisfiable split requests is to return {{null}}.
> However, {{BigtableIO.Read}} will currently throw for simply invalid input it 
> should reject. This can lead to less effective dynamic work rebalancing and 
> even stuck jobs.
> Related to, but probably not a complete solution for, [BEAM-1751].



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to