[
https://issues.apache.org/jira/browse/BEAM-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15942410#comment-15942410
]
ASF GitHub Bot commented on BEAM-1772:
--------------------------------------
GitHub user JingsongLi opened a pull request:
https://github.com/apache/beam/pull/2331
[BEAM-1772] Support merging WindowFn other than IntervalWindow on Flink
Runner
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JingsongLi/beam BEAM-1772
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2331.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2331
----
commit 03bbbf98f57c3b9590a83264945f8a6fa4dfd17a
Author: JingsongLi <[email protected]>
Date: 2017-03-26T18:09:32Z
Abstract combine in Flink Batch Runner
commit ca0098795e73a1c004c059048158cc762a133fc3
Author: JingsongLi <[email protected]>
Date: 2017-03-26T19:05:57Z
[BEAM-1772] Support merging WindowFn other than IntervalWindow on Flink
Runner
----
> Support merging WindowFn other than IntervalWindow on Flink Runner
> ------------------------------------------------------------------
>
> Key: BEAM-1772
> URL: https://issues.apache.org/jira/browse/BEAM-1772
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Ismaël Mejía
> Assignee: Jingsong Lee
>
> Flink currently supports merging IntervalWindows, however if you have a
> WindowFn who extends IntervalWindow the execution breaks.
> I found this while executing a Pipeline in Flink's batch mode.
> This will involve probably changing the window merging logic in
> `FlinkMergingReduceFunction.mergeWindows()` and other similar parts to really
> use the merging logic of the `WindowFn`.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
