[
https://issues.apache.org/jira/browse/BEAM-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15942509#comment-15942509
]
ASF GitHub Bot commented on BEAM-1760:
--------------------------------------
GitHub user tedyu opened a pull request:
https://github.com/apache/beam/pull/2332
BEAM-1760 Potential null dereference in HDFSFileSink#doFinalize
Check whether s.getPath().getParent() is null.
If it is null, break out of the loop.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tedyu/beam master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2332.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2332
----
commit 6a36f605e6ba36559ebc71b9551c7fa2308fe906
Author: tedyu <[email protected]>
Date: 2017-03-27T00:49:47Z
BEAM-1760 Potential null dereference in HDFSFileSink#doFinalize
----
> Potential null dereference in HDFSFileSink#doFinalize
> -----------------------------------------------------
>
> Key: BEAM-1760
> URL: https://issues.apache.org/jira/browse/BEAM-1760
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Minor
>
> Here is related code:
> {code}
> for (FileStatus s : statuses) {
> String name = s.getPath().getName();
> int pos = name.indexOf('.');
> String ext = pos > 0 ? name.substring(pos) : "";
> fs.rename(
> s.getPath(),
> new Path(s.getPath().getParent(), String.format("part-r-%05d%s",
> i, ext)));
> i++;
> }
> }
> {code}
> We should check whether s.getPath().getParent() is null.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
