GitHub user dlebech opened a pull request:
https://github.com/apache/beam/pull/2333
[BEAM-1648] Replace gsutil with storage API calls
This PR replaces the `gsutil cp` call with a GCS API call when staging
resources.
I was unsure how to unit test this feature, and given that the existing
functionality was not under test already, I just tested this with the following
script:
```python
from apache_beam.runners.dataflow.internal import dependency
dependency._dependency_file_copy('/home/david/myfile.txt',
'gs://mybucket/myfile.txt')
dependency._dependency_file_copy('gs://mybucket/myfile.txt',
'gs://mybucket/myfile2.txt')
dependency._dependency_file_copy('gs://mybucket/myfile2.txt',
'/home/david/myfile2.txt')
```
All three operations are successful.
I've set up travis-ci for the build, and it is successful for the python
tests but not the Java tests (it looks like this is a general issue at the
moment).
---
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/getconversio/beam gs-util-abolish
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2333.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2333
----
commit 06948a1accb0cef77a304e4a805e0eec54797013
Author: David Volquartz Lebech <[email protected]>
Date: 2017-03-27T10:18:18Z
Replace gsutil with storage API calls
This commit replaces the `gsutil cp` call with GCS API call when staging
resources.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
