[
https://issues.apache.org/jira/browse/BEAM-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946065#comment-15946065
]
ASF GitHub Bot commented on BEAM-1441:
--------------------------------------
GitHub user sb2nov opened a pull request:
https://github.com/apache/beam/pull/2350
BEAM-1441 Fix bugs in Temp IOChannelFactory in FileIO
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sb2nov/beam BEAM-fix-fileio-bugss
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2350.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2350
----
commit 5b00b1bed6c10e38c69e58b2a8fab3f591a117c9
Author: Sourabh Bajaj <[email protected]>
Date: 2017-03-28T21:15:20Z
Fix bugs in fileio in the Temp IOFactory
----
> Add an IOChannelFactory interface to Python SDK
> -----------------------------------------------
>
> Key: BEAM-1441
> URL: https://issues.apache.org/jira/browse/BEAM-1441
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py
> Reporter: Chamikara Jayalath
> Assignee: Sourabh Bajaj
> Fix For: First stable release
>
>
> Based on proposal [1], an IOChannelFactory interface was added to Java SDK
> [2].
> We should add a similar interface to Python SDK and provide proper
> implementations for native files, GCS, and other useful formats.
> Python SDK currently has a basic ChannelFactory interface [3] which is used
> by FileBasedSource [4].
> [1]
> https://docs.google.com/document/d/11TdPyZ9_zmjokhNWM3Id-XJsVG3qel2lhdKTknmZ_7M/edit#heading=h.kpqagzh8i11w
> [2]
> https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/util/IOChannelFactory.java
> [3]
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/fileio.py#L107
> [4]
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/filebasedsource.py
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
