GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/2353
[BEAM-41,BEAM-42] Revise MapState and SetState APIs to leverage
ReadableState
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
@JingsongLi and @aljoscha I think you two have the most familiarity with
this.
This updates the `MapState` and `SetState` API so the methods return
`ReadableState` instead of duplicating the design pattern for every method.
This makes it so there is really just one `readLater()` and we use it wherever
we need a future-like value.
I have pushed just the API changes to get feedback, and then I will change
the in-memory state.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam more-state
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2353.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2353
----
commit b837814020494329731ecaab43ae39466dcb3fd5
Author: Kenneth Knowles <[email protected]>
Date: 2017-03-29T03:08:45Z
Revise MapState and SetState APIs to leverage ReadableState
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
