[ 
https://issues.apache.org/jira/browse/BEAM-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957113#comment-15957113
 ] 

ASF GitHub Bot commented on BEAM-1881:
--------------------------------------

GitHub user dhalperi opened a pull request:

    https://github.com/apache/beam/pull/2433

    [BEAM-1881] Exclude protobuf-lite and replace with protobuf-java

    They are not compatible; protobuf-lite is only intended for use with 
Android.
    
    R: @iemejia 
    
    Please take a look :)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/beam no-protobuf-lite

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2433.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2433
    
----

----


> Exclude protobuf-lite everywhere
> --------------------------------
>
>                 Key: BEAM-1881
>                 URL: https://issues.apache.org/jira/browse/BEAM-1881
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Daniel Halperin
>            Assignee: Daniel Halperin
>             Fix For: First stable release
>
>
> Protobuf-lite and protobuf-java are completely incompatible. Apparently, 
> protobuf-lite is not "lite", it should really be used only in Android.
> So we should be very careful to exclude -lite everywhere and enforce java.
> And if possible, use an enforcer to prevent any dependencies on -lite ever.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to