[
https://issues.apache.org/jira/browse/BEAM-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959239#comment-15959239
]
Thomas Groh commented on BEAM-819:
----------------------------------
I believe so.
The fix probably consists of draining the active {{ExecutorServices}} in
{{ExecutorServiceParallelExecutor#shutdownIfNecessary}}, and ensuring that none
of the active executions threw an exception. I expect that waiting on the call
to {{shutdown()}} using {{awaitTermination}} would suffice, as it should be an
orderly shutdown (where no future tasks are accepted but all currently active
tasks complete).
> The DirectRunner can complete before reporting the results of all
> ModelEnforcements
> -----------------------------------------------------------------------------------
>
> Key: BEAM-819
> URL: https://issues.apache.org/jira/browse/BEAM-819
> Project: Beam
> Issue Type: Bug
> Components: runner-direct
> Reporter: Thomas Groh
> Assignee: Thomas Groh
>
> The termination condition in the
> ExecutorServiceParallelExecutor.MonitorRunnable checks to see if the
> evaluation context is done, among other things. Due to the signatures of
> ModelEnforcement, output is committed before ModelEnforcement runs to ensure
> that the enforcement has access to the final elements. If the transform that
> performs ModelEnforcement completes, and all PTransforms are done, the
> pipeline can shutdown before model enforcement fails.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
