[
https://issues.apache.org/jira/browse/BEAM-778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959978#comment-15959978
]
ASF GitHub Bot commented on BEAM-778:
-------------------------------------
GitHub user sb2nov opened a pull request:
https://github.com/apache/beam/pull/2456
[BEAM-778] Fix the Compressed file seek tests on windows
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
R: @chamikaramj @tibkiss
The seek tests were failing on windows due to two main reasons: (1) files
not being closed before removing and (2) files not being opened as binary
files.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sb2nov/beam BEAM-windows-test-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2456.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2456
----
commit ee225fa2c9489daa8c4b650f2a30d5d55b0a1f3d
Author: Sourabh Bajaj <[email protected]>
Date: 2017-04-06T23:23:33Z
[BEAM-778] Fix the Compressed file seek tests on windows
----
> Make filesystem._CompressedFile seekable.
> -----------------------------------------
>
> Key: BEAM-778
> URL: https://issues.apache.org/jira/browse/BEAM-778
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py
> Reporter: Chamikara Jayalath
> Assignee: Tibor Kiss
> Fix For: Not applicable
>
>
> We have a TODO to make filesystem._CompressedFile seekable.
> https://github.com/apache/incubator-beam/blob/python-sdk/sdks/python/apache_beam/io/fileio.py#L692
> Without this, compressed file objects produce for FileBasedSource
> implementations may not be able to use libraries that utilize methods seek()
> and tell().
> For example tarfile.open().
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
