[
https://issues.apache.org/jira/browse/BEAM-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963487#comment-15963487
]
ASF GitHub Bot commented on BEAM-1222:
--------------------------------------
GitHub user sb2nov opened a pull request:
https://github.com/apache/beam/pull/2483
[BEAM-1222] Chunk size should be FS dependent
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
R: @chamikaramj PTAL
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sb2nov/beam BEAM-1222-rename-batch-consistency
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2483.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2483
----
commit 48bb983aa3d216356abc60f5919f5e7b914e58b5
Author: Sourabh Bajaj <[email protected]>
Date: 2017-04-10T21:09:48Z
[BEAM-1222] Chunk size should be FS dependent
----
> Move GCS specific constants out of fileio
> -----------------------------------------
>
> Key: BEAM-1222
> URL: https://issues.apache.org/jira/browse/BEAM-1222
> Project: Beam
> Issue Type: Bug
> Components: sdk-py
> Reporter: Chamikara Jayalath
> Assignee: Sourabh Bajaj
>
> Currently fileio.py has GCS specific constant gcsio.MAX_BATCH_OPERATION_SIZE
> which should be moved out of it. This will be needed to implement
> IOChannelFactory proposal [1] for Python SDK.
> [1]
> https://docs.google.com/document/d/11TdPyZ9_zmjokhNWM3Id-XJsVG3qel2lhdKTknmZ_7M/edit#heading=h.kpqagzh8i11w
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
