[
https://issues.apache.org/jira/browse/BEAM-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15964280#comment-15964280
]
ASF GitHub Bot commented on BEAM-1907:
--------------------------------------
Github user asfgit closed the pull request at:
https://github.com/apache/beam/pull/2471
> Delete PubsubBoundedReader
> --------------------------
>
> Key: BEAM-1907
> URL: https://issues.apache.org/jira/browse/BEAM-1907
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-gcp
> Reporter: Daniel Halperin
> Assignee: Daniel Halperin
> Fix For: First stable release
>
>
> PubsubIO in bounded mode doesn't really make sense, outside of hacky testing
> modes -- it might lose data, other stuff that's sketchy. We had it before
> because the old {{DirectRunner}} did not support unbounded PCollections. Now
> that it does, we should probably get rid of this buggy code.
> Specifically:
> * Delete the specialized PubsubBoundedReader implementation
> * Either: delete the maxNumRecords and maxReadTime methods, or rename them to
> something like maxNumRecordsForTesting with clear javadoc as to their
> drawbacks.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
