[beam] branch release-2.42.0 updated: Fix IllegalStateException in StorageApiWriteUnshardedRecords error handling. (#23233)

[lostluck]

This is an automated email from the ASF dual-hosted git repository.

lostluck pushed a commit to branch release-2.42.0
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/release-2.42.0 by this push:
     new 135877e04a0 Fix IllegalStateException in 
StorageApiWriteUnshardedRecords error handling. (#23233)
135877e04a0 is described below

commit 135877e04a0d4e0349c48b65ebd974a20d764a41
Author: Sam Whittle <scwhit...@users.noreply.github.com>
AuthorDate: Wed Sep 14 19:54:43 2022 +0200

    Fix IllegalStateException in StorageApiWriteUnshardedRecords error 
handling. (#23233)
    
    Fixes #23063
---
 .../sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java  | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git 
a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java
 
b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java
index 2e627e86c74..607f06c4e00 100644
--- 
a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java
+++ 
b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java
@@ -372,15 +372,14 @@ public class 
StorageApiWriteUnshardedRecords<DestinationT, ElementT>
 
       String retrieveErrorDetails(Iterable<Context<AppendRowsResponse>> 
contexts) {
         return StreamSupport.stream(contexts.spliterator(), false)
-            .map(ctx -> Preconditions.checkStateNotNull(ctx.getError()))
+            .<@Nullable Throwable>map(ctx -> ctx.getError())
             .map(
                 err ->
-                    String.format(
-                        "message: %s, stacktrace: %s",
-                        err,
-                        Lists.newArrayList(err.getStackTrace()).stream()
+                    (err == null)
+                        ? "no error"
+                        : Lists.newArrayList(err.getStackTrace()).stream()
                             .map(se -> se.toString())
-                            .collect(Collectors.joining("\n"))))
+                            .collect(Collectors.joining("\n")))
             .collect(Collectors.joining(","));
       }
     }