[
https://issues.apache.org/jira/browse/BEAM-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968501#comment-15968501
]
ASF GitHub Bot commented on BEAM-1179:
--------------------------------------
GitHub user chamikaramj opened a pull request:
https://github.com/apache/beam/pull/2536
[BEAM-1179] Renames assertions of source_test_utils
Renames assertions of source_test_utils from camelcase to
underscore-separated.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chamikaramj/beam rename_sourcetestutil_asserts
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2536.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2536
----
commit 82ba164b6f0ca69abbc707163232fa5b5791dc9a
Author: [email protected] <[email protected]>
Date: 2017-04-14T01:57:04Z
Update assertions of source_test_utils from camelcase to
underscore-separated.
----
> Update assertions of source_test_utils from camelcase to underscore-separated
> -----------------------------------------------------------------------------
>
> Key: BEAM-1179
> URL: https://issues.apache.org/jira/browse/BEAM-1179
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py
> Reporter: Chamikara Jayalath
> Assignee: Chamikara Jayalath
> Fix For: First stable release
>
>
> Assertions in source_test_utils module [1] currently have method names in
> camel case. This was original done so that it's similar to assertions in
> Python unittest module. But it's better to deprecate these and add
> underscore-separated variations so that code in Python SDK is consistent.
> [1]
> https://github.com/apache/incubator-beam/blob/python-sdk/sdks/python/apache_beam/io/source_test_utils.py
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
