[ 
https://issues.apache.org/jira/browse/BEAM-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974960#comment-15974960
 ] 

ASF GitHub Bot commented on BEAM-1984:
--------------------------------------

GitHub user iemejia opened a pull request:

    https://github.com/apache/beam/pull/2591

    [BEAM-1984] Enable dependency analysis of non-compile dependencies

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/iemejia/beam 
BEAM-1984-enable-dep-analysis-for-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2591.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2591
    
----
commit 852d8aea354714a6d4b2ca6121fba454a9939de3
Author: Ismaël Mejía <[email protected]>
Date:   2017-04-13T16:52:58Z

    [BEAM-1984] Update maven surefire and failsafe plugins to version 2.20

commit 14af68d717e87162bbda81c7f64d456f82182674
Author: Ismaël Mejía <[email protected]>
Date:   2017-04-16T12:41:44Z

    [BEAM-1984] Fix scope for dependencies needed only for test purposes

commit 28bbca63b474cd622a99a67bc30b2e6370368138
Author: Ismaël Mejía <[email protected]>
Date:   2017-04-17T21:34:12Z

    [BEAM-1984] Enable runtime dependency analysis

----


> Enable dependency analysis of non-compile dependencies
> ------------------------------------------------------
>
>                 Key: BEAM-1984
>                 URL: https://issues.apache.org/jira/browse/BEAM-1984
>             Project: Beam
>          Issue Type: Improvement
>          Components: build-system
>    Affects Versions: Not applicable
>            Reporter: Ismaël Mejía
>            Assignee: Ismaël Mejía
>            Priority: Minor
>
> Currently the dependency analysis is ignoring test dependencies, however if 
> we run:
> mvn install -Dmaven.test.skip=true
> It complains on multiple modules on dependencies that should be scoped 
> properly into the test mode but aren’t currently.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to