[
https://issues.apache.org/jira/browse/BEAM-662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975642#comment-15975642
]
ASF GitHub Bot commented on BEAM-662:
-------------------------------------
GitHub user sb2nov opened a pull request:
https://github.com/apache/beam/pull/2600
[BEAM-662] Fix for allowing floating point periods in windows
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
R: @robertwb, @aaltay PTAL
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sb2nov/beam
BEAM-662-sliding-windows-rounding-off
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2600.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2600
----
commit 2252dca066e3bd8712bfef1cacf493e3d99c5ecb
Author: Sourabh Bajaj <[email protected]>
Date: 2017-04-19T22:13:26Z
[BEAM-662] Fix for allowing floating point periods in windows
----
> SlidingWindows should support sub-second periods
> ------------------------------------------------
>
> Key: BEAM-662
> URL: https://issues.apache.org/jira/browse/BEAM-662
> Project: Beam
> Issue Type: Bug
> Components: sdk-py
> Reporter: Daniel Mills
> Assignee: Sourabh Bajaj
> Priority: Minor
> Fix For: First stable release
>
>
> SlidingWindows periods are being rounded to seconds, see
> http://stackoverflow.com/questions/39604646/can-slidingwindows-have-half-second-periods-in-python-apache-beam
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
