GitHub user dhalperi opened a pull request:
https://github.com/apache/beam/pull/2633
Make it possible to test runners that don't support all metrics
Runners may only partially support metrics. This partial support runs along
axes:
- attempted & committed
- counters & distributions & gauges & ...
Prior to this PR, we have categories for the first axis, but not the second.
This means that a runner that supports only part of the second axis has to
blacklist tests
on the first axis. Adding categories for both axes lets runners build a
matrix of supported
features.
I also renamed the existing categories so that they are grouped
alphabetically. Happy to
undo if this is not a good change.
This also lets the DataflowRunner run more tests by accurately identifying
its test
matrix.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dhalperi/beam metrics-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2633.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2633
----
commit d2dab0acdcd5e54a66878a12e30fc88fc31ede9a
Author: Dan Halperin <[email protected]>
Date: 2017-04-21T17:03:50Z
Make it possible to test runners that don't support all metrics
Runners may only partially support metrics. This partial support runs along
axes:
- attempted & committed
- counters & distributions & gauges & ...
Prior to this PR, we have categories for the first axis, but not the second.
This means that a runner that supports only part of the second axis has to
blacklist tests
on the first axis. Adding categories for both axes lets runners build a
matrix of supported
features.
I also renamed the exiting categories so that they are grouped
alphabetically. Happy to
undo if this is not a good change.
This also lets the DataflowRunner run more tests by accurately identifying
its test
matrix.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
