This is an automated email from the ASF dual-hosted git repository.
johncasey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push:
new 260d8666a60 resume running flaky test (#24648)
260d8666a60 is described below
commit 260d8666a603869ca45ebe1e3c439be71c75b3e1
Author: johnjcasey <[email protected]>
AuthorDate: Thu Dec 15 15:39:19 2022 -0500
resume running flaky test (#24648)
* resume running flaky test
* remove commented ignores
---
.../beam/sdk/extensions/python/PythonExternalTransform.java | 12 ++++++------
.../sdk/extensions/python/PythonExternalTransformTest.java | 10 +++-------
2 files changed, 9 insertions(+), 13 deletions(-)
diff --git
a/sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/PythonExternalTransform.java
b/sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/PythonExternalTransform.java
index b3feb6df16d..4246b426a3e 100644
---
a/sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/PythonExternalTransform.java
+++
b/sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/PythonExternalTransform.java
@@ -138,14 +138,14 @@ public class PythonExternalTransform<InputT extends
PInput, OutputT extends POut
* ...valuesForMyPTransformConstructorIfAny);
* </pre>
*
- * @param tranformName fully qualified transform name.
+ * @param transformName fully qualified transform name.
* @param <InputT> Input {@link PCollection} type
* @param <OutputT> Output {@link PCollection} type
* @return A {@link PythonExternalTransform} for the given transform name.
*/
public static <InputT extends PInput, OutputT extends POutput>
- PythonExternalTransform<InputT, OutputT> from(String tranformName) {
- return new PythonExternalTransform<>(tranformName, "");
+ PythonExternalTransform<InputT, OutputT> from(String transformName) {
+ return new PythonExternalTransform<>(transformName, "");
}
/**
@@ -153,15 +153,15 @@ public class PythonExternalTransform<InputT extends
PInput, OutputT extends POut
*
* <p>See {@link PythonExternalTransform#from(String)} for the meaning of
transformName.
*
- * @param tranformName fully qualified transform name.
+ * @param transformName fully qualified transform name.
* @param expansionService address and port number for externally launched
expansion service
* @param <InputT> Input {@link PCollection} type
* @param <OutputT> Output {@link PCollection} type
* @return A {@link PythonExternalTransform} for the given transform name.
*/
public static <InputT extends PInput, OutputT extends POutput>
- PythonExternalTransform<InputT, OutputT> from(String tranformName,
String expansionService) {
- return new PythonExternalTransform<>(tranformName, expansionService);
+ PythonExternalTransform<InputT, OutputT> from(String transformName,
String expansionService) {
+ return new PythonExternalTransform<>(transformName, expansionService);
}
/**
diff --git
a/sdks/java/extensions/python/src/test/java/org/apache/beam/sdk/extensions/python/PythonExternalTransformTest.java
b/sdks/java/extensions/python/src/test/java/org/apache/beam/sdk/extensions/python/PythonExternalTransformTest.java
index 72cbeae1d27..735f6dd5eba 100644
---
a/sdks/java/extensions/python/src/test/java/org/apache/beam/sdk/extensions/python/PythonExternalTransformTest.java
+++
b/sdks/java/extensions/python/src/test/java/org/apache/beam/sdk/extensions/python/PythonExternalTransformTest.java
@@ -34,15 +34,13 @@ import org.apache.beam.sdk.testing.PAssert;
import org.apache.beam.sdk.testing.UsesPythonExpansionService;
import org.apache.beam.sdk.testing.ValidatesRunner;
import org.apache.beam.sdk.transforms.Create;
-import org.apache.beam.sdk.transforms.MapElements;
+import org.apache.beam.sdk.transforms.Keys;
import org.apache.beam.sdk.util.PythonCallableSource;
import org.apache.beam.sdk.values.KV;
import org.apache.beam.sdk.values.PCollection;
import org.apache.beam.sdk.values.Row;
-import org.apache.beam.sdk.values.TypeDescriptors;
import
org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.ImmutableList;
import
org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.ImmutableMap;
-import org.junit.Ignore;
import org.junit.Test;
import org.junit.experimental.categories.Category;
import org.junit.runner.RunWith;
@@ -50,8 +48,7 @@ import org.junit.runners.JUnit4;
@RunWith(JUnit4.class)
public class PythonExternalTransformTest implements Serializable {
- @Ignore("https://github.com/apache/beam/issues/21561";)
- @Test
+
@Category({ValidatesRunner.class, UsesPythonExpansionService.class})
public void trivialPythonTransform() {
Pipeline p = Pipeline.create();
@@ -61,12 +58,11 @@ public class PythonExternalTransformTest implements
Serializable {
PythonExternalTransform
.<PCollection<KV<String, String>>, PCollection<KV<String,
Iterable<String>>>>
from("apache_beam.GroupByKey"))
- .apply(MapElements.into(TypeDescriptors.strings()).via(kv ->
kv.getKey()));
+ .apply(Keys.create());
PAssert.that(output).containsInAnyOrder("A", "B");
// TODO: Run this on a multi-language supporting runner.
}
- @Ignore("https://github.com/apache/beam/issues/21561";)
@Test
@Category({ValidatesRunner.class, UsesPythonExpansionService.class})
public void pythonTransformWithDependencies() {
