This is an automated email from the ASF dual-hosted git repository.

tvalentyn pushed a commit to branch revert-26015-ohsaycanyouc
in repository https://gitbox.apache.org/repos/asf/beam.git

commit 56868a26687585c3b721e4c0b9574b588c8c5174
Author: tvalentyn <[email protected]>
AuthorDate: Tue Apr 25 14:10:58 2023 +0200

    Revert "Add explicit language_level=3 arg to Cythonize (#26015)"
    
    This reverts commit 14a77825928592635de755c1ab2fdb52c20b8e7d.
---
 sdks/python/setup.py | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/sdks/python/setup.py b/sdks/python/setup.py
index dbff4db2575..bbcc79ce9ca 100644
--- a/sdks/python/setup.py
+++ b/sdks/python/setup.py
@@ -36,7 +36,7 @@ from setuptools import Command
 # It is recommended to import setuptools prior to importing distutils to avoid
 # using legacy behavior from distutils.
 # https://setuptools.readthedocs.io/en/latest/history.html#v48-0-0
-from distutils.errors import DistutilsError  # isort:skip
+from distutils.errors import DistutilsError # isort:skip
 
 
 class mypy(Command):
@@ -127,7 +127,6 @@ except DistributionNotFound:
 try:
   # pylint: disable=wrong-import-position
   from Cython.Build import cythonize as cythonize0
-
   def cythonize(*args, **kwargs):
     import numpy
     extensions = cythonize0(*args, **kwargs)
@@ -151,7 +150,6 @@ dataframe_dependency = [
     'pandas>=1.4.3,!=1.5.0,!=1.5.1,<1.6;python_version>="3.8"',
 ]
 
-
 # We must generate protos after setup_requires are installed.
 def generate_protos_first():
   try:
@@ -213,6 +211,7 @@ if __name__ == '__main__':
           ]
       },
       ext_modules=cythonize([
+          # Make sure to use language_level=3 cython directive in files below.
           'apache_beam/**/*.pyx',
           'apache_beam/coders/coder_impl.py',
           'apache_beam/metrics/cells.py',
@@ -225,7 +224,7 @@ if __name__ == '__main__':
           'apache_beam/transforms/stats.py',
           'apache_beam/utils/counters.py',
           'apache_beam/utils/windowed_value.py',
-      ], language_level=3),
+      ]),
       install_requires = [
         'crcmod>=1.7,<2.0',
         'orjson<4.0',

Reply via email to