Repository: beam Updated Branches: refs/heads/master 412b610ed -> a0b077f5e
update JavaDoc for Count.globally Project: http://git-wip-us.apache.org/repos/asf/beam/repo Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/ea230f1a Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/ea230f1a Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/ea230f1a Branch: refs/heads/master Commit: ea230f1a48315364e4cf683c1051db9b8906bd59 Parents: 412b610 Author: mingmxu <[email protected]> Authored: Wed Apr 19 16:11:03 2017 -0700 Committer: Eugene Kirpichov <[email protected]> Committed: Wed Apr 26 19:00:50 2017 -0700 ---------------------------------------------------------------------- .../core/src/main/java/org/apache/beam/sdk/transforms/Count.java | 4 ++++ 1 file changed, 4 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/beam/blob/ea230f1a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Count.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Count.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Count.java index abda1c6..34a5c57 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Count.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Count.java @@ -28,6 +28,7 @@ import org.apache.beam.sdk.coders.CoderException; import org.apache.beam.sdk.coders.CoderRegistry; import org.apache.beam.sdk.coders.CustomCoder; import org.apache.beam.sdk.transforms.Combine.CombineFn; +import org.apache.beam.sdk.transforms.windowing.GlobalWindows; import org.apache.beam.sdk.util.VarInt; import org.apache.beam.sdk.values.KV; import org.apache.beam.sdk.values.PCollection; @@ -57,6 +58,9 @@ public class Count { /** * Returns a {@link PTransform} that counts the number of elements in * its input {@link PCollection}. + * + * <p>Note: if the input collection uses a windowing strategy other than {@link GlobalWindows}, + * use {@code Combine.globally(Count.<T>combineFn()).withoutDefaults()} instead. */ public static <T> PTransform<PCollection<T>, PCollection<Long>> globally() { return Combine.globally(new CountFn<T>());
