Repository: beam Updated Branches: refs/heads/master b57ae2633 -> 1119711a1
Rename openWindows => windowsThatAreOpen to make its name have parallel structure with windowsThatShouldFire Project: http://git-wip-us.apache.org/repos/asf/beam/repo Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/59a58073 Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/59a58073 Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/59a58073 Branch: refs/heads/master Commit: 59a580735384fd72374f263588b41819e9a415e1 Parents: 4a8e5d5 Author: wtanaka.com <[email protected]> Authored: Sat Apr 22 15:48:32 2017 -1000 Committer: wtanaka.com <[email protected]> Committed: Sat Apr 22 15:48:32 2017 -1000 ---------------------------------------------------------------------- .../main/java/org/apache/beam/runners/core/ReduceFnRunner.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/beam/blob/59a58073/runners/core-java/src/main/java/org/apache/beam/runners/core/ReduceFnRunner.java ---------------------------------------------------------------------- diff --git a/runners/core-java/src/main/java/org/apache/beam/runners/core/ReduceFnRunner.java b/runners/core-java/src/main/java/org/apache/beam/runners/core/ReduceFnRunner.java index 34db752..c9f6bba 100644 --- a/runners/core-java/src/main/java/org/apache/beam/runners/core/ReduceFnRunner.java +++ b/runners/core-java/src/main/java/org/apache/beam/runners/core/ReduceFnRunner.java @@ -264,7 +264,7 @@ public class ReduceFnRunner<K, InputT, OutputT, W extends BoundedWindow> { return activeWindows.getActiveAndNewWindows().isEmpty(); } - private Set<W> openWindows(Collection<W> windows) { + private Set<W> windowsThatAreOpen(Collection<W> windows) { Set<W> result = new HashSet<>(); for (W window : windows) { ReduceFn<K, InputT, OutputT, W>.Context directContext = contextFactory.base( @@ -339,7 +339,7 @@ public class ReduceFnRunner<K, InputT, OutputT, W extends BoundedWindow> { prefetchWindowsForValues(windows); // All windows that are open before element processing may need to fire. - Set<W> windowsToConsider = openWindows(windows); + Set<W> windowsToConsider = windowsThatAreOpen(windows); // Process each element, using the updated activeWindows determined by mergeWindows. for (WindowedValue<InputT> value : values) {
