Stas Levin created BEAM-2092:
--------------------------------
Summary: MicrobatchSource can be relieved of some of its methods
since it's never used as an actual BoundedSource
Key: BEAM-2092
URL: https://issues.apache.org/jira/browse/BEAM-2092
Project: Beam
Issue Type: Bug
Components: runner-spark
Reporter: Stas Levin
Assignee: Stas Levin
Priority: Minor
Currently {{MicrobatchSource}} extends {{BoundedSource}}, and thus must
implement its members (e.g., {{getEstimatedSizeBytes}}, {{createReader}}, etc.).
Since {{MicrobatchSource}} is never actually used as a {{BoundedSource}}, it
may derive directly from {{Source}}, which will allow removing some of its
methods that are not being used.
Similarly, {{MicrobatchSource.Reader}} does not perfectly fit the concepts of
{{BoundedSource.BoundedReader}}, since it is actually a sort of hybrid between
a bounded and an unbounded readers, and most resembles the
{{BoundedReadFromUnboundedSource.UnboundedToBoundedSourceAdapter}} class. This
makes it a nice candidate for deriving directly from {{Source.Reader}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
