[
https://issues.apache.org/jira/browse/BEAM-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986828#comment-15986828
]
ASF GitHub Bot commented on BEAM-2096:
--------------------------------------
GitHub user dhalperi opened a pull request:
https://github.com/apache/beam/pull/2739
[BEAM-2096] Make DataflowMetrics more resilient
DataflowMetrics seems to have many hard-coded assumptions about what will be
returned by the Dataflow service that, which will likely break when users
use new types of metrics or if the Dataflow service makes minor adjustments
in our it sends metrics back to the user.
In order for code to continue working in these cases, handle errors by
logging
and skipping.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dhalperi/beam metrics-npe
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2739.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2739
----
commit 4f418cdd57c5ebff2f406c1487db7dee420e3df6
Author: Dan Halperin <[email protected]>
Date: 2017-04-27T15:30:47Z
[BEAM-2096] Make DataflowMetrics more resilient
DataflowMetrics seems to have many hard-coded assumptions about what will be
returned by the Dataflow service that, which will likely break when users
use new types of metrics or if the Dataflow service makes minor adjustments
in our it sends metrics back to the user.
In order for code to continue working in these cases, handle errors by
logging
and skipping.
----
> NullPointerException in DataflowMetrics
> ---------------------------------------
>
> Key: BEAM-2096
> URL: https://issues.apache.org/jira/browse/BEAM-2096
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Kenneth Knowles
> Assignee: Pablo Estrada
> Priority: Blocker
> Fix For: First stable release
>
>
> This started failing some time yesterday it looks like:
> https://builds.apache.org/view/Beam/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/2949/#showFailuresLink
> Possible culprit at
> https://github.com/apache/beam/commit/4faa8feba822db000b4b42636408245422ed324d#diff-fff6f69683ac0e26db7e3ad095d7cdf0
> since that is when it starting failing.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
