[
https://issues.apache.org/jira/browse/BEAM-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990193#comment-15990193
]
Stas Levin edited comment on BEAM-1676 at 4/30/17 11:31 AM:
------------------------------------------------------------
We can internalize (euphemism for copy-paste) the fixed {{ClassPath}} class
implementation from the {{Guava}} master, and use it within {{ApiSurface}} (by
keeping it private to {{ApiSurface}} it should prevent any clashes with the
other {{ClassPath}} class residing in the current {{Guava}} version).
I have played with it briefly and it looks ok.
What do you think?
was (Author: staslev):
We can internalise (euphemism for copy-paste) the fixed {{ClassPath}} class
implementation from the {{Guava}} master, and use it within {{ApiSurface}} (by
keeping it private to {{ApiSurface}} it should prevent any clashes with the
other {{ClassPath}} class residing in the current {{Guava}} version).
I have played with it briefly and it looks ok.
What do you think?
> SdkCoreApiSurfaceTest Failed When Directory Contains Space
> ----------------------------------------------------------
>
> Key: BEAM-1676
> URL: https://issues.apache.org/jira/browse/BEAM-1676
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Mark Liu
> Assignee: Stas Levin
>
> Test failed if build directory contains space. For example: "~/dir with
> space/beam/..."
> The failure happened on Jenkins and can be reproduced from local.
> GcpApiSurfaceTest may have same problem.
> error is:
> {code}
> Failed tests:
> SdkCoreApiSurfaceTest.testSdkApiSurface:59
> Expected: API surface to include only:
> Classes in package "org.apache.beam"
> Classes in package "com.google.api.client"
> Classes in package "com.google.api.services.bigquery"
> Classes in package "com.google.api.services.cloudresourcemanager"
> Classes in package "com.google.api.services.pubsub"
> Classes in package "com.google.api.services.storage"
> Classes in package "com.google.auth"
> Classes in package "com.google.protobuf"
> Classes in package "com.fasterxml.jackson.annotation"
> Classes in package "com.fasterxml.jackson.core"
> Classes in package "com.fasterxml.jackson.databind"
> Classes in package "org.apache.avro"
> Classes in package "org.hamcrest"
> Classes in package "org.codehaus.jackson"
> Classes in package "org.joda.time"
> Classes in package "org.junit"
>
> but: The following white-listed scopes did not have matching classes on
> the API surface:
> No Classes in package "com.fasterxml.jackson.annotation"
> No Classes in package "com.fasterxml.jackson.core"
> No Classes in package "com.fasterxml.jackson.databind"
> No Classes in package "com.google.api.client"
> No Classes in package "com.google.api.services.bigquery"
> No Classes in package "com.google.api.services.cloudresourcemanager"
> No Classes in package "com.google.api.services.pubsub"
> No Classes in package "com.google.api.services.storage"
> No Classes in package "com.google.auth"
> No Classes in package "com.google.protobuf"
> No Classes in package "org.apache.avro"
> No Classes in package "org.apache.beam"
> No Classes in package "org.codehaus.jackson"
> No Classes in package "org.hamcrest"
> No Classes in package "org.joda.time"
> No Classes in package "org.junit"
> {code}
> Job link from Jenkins:
> https://builds.apache.org/job/beam_PostCommit_Java_Version_Test/14/
> One of the Jenkins job uses "JDK 1.8 (latest)" which is also part of project
> directory.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
