This is an automated email from the ASF dual-hosted git repository. yhu pushed a commit to branch revert-30417-feature/add-jdbc-python-query-overwrite-test in repository https://gitbox.apache.org/repos/asf/beam.git
commit cfa6b4b7b47cedbb833a61ac656c9571cac7e41f Author: Yi Hu <[email protected]> AuthorDate: Tue Mar 5 23:11:29 2024 -0500 Revert "Add test code to overwrite SQL in Beam Python JDBC (#30417)" This reverts commit 2b8a737ebd0942da69f0988180e3c9160b267ba2. --- .../io/external/xlang_jdbcio_it_test.py | 24 ++-------------------- 1 file changed, 2 insertions(+), 22 deletions(-) diff --git a/sdks/python/apache_beam/io/external/xlang_jdbcio_it_test.py b/sdks/python/apache_beam/io/external/xlang_jdbcio_it_test.py index 9d8b8f92795..54a473d1b52 100644 --- a/sdks/python/apache_beam/io/external/xlang_jdbcio_it_test.py +++ b/sdks/python/apache_beam/io/external/xlang_jdbcio_it_test.py @@ -29,8 +29,6 @@ from typing import Union from parameterized import parameterized import apache_beam as beam -from apache_beam import DoFn -from apache_beam import ParDo from apache_beam import coders from apache_beam.io.jdbc import ReadFromJdbc from apache_beam.io.jdbc import WriteToJdbc @@ -199,6 +197,8 @@ class CrossLanguageJdbcIOTest(unittest.TestCase): p.not_use_test_runner_api = True result = ( p + # TODO(https://github.com/apache/beam/issues/20446) Add test with + # overridden read_query | 'Read from jdbc' >> ReadFromJdbc( table_name=table_name, driver_class_name=self.driver_class_name, @@ -209,26 +209,6 @@ class CrossLanguageJdbcIOTest(unittest.TestCase): assert_that(result, equal_to(expected_row)) - with TestPipeline() as p: - p.not_use_test_runner_api = True - - class ExtractCount(DoFn): - def process(self, element): - yield element[0] - - result = ( - p - | 'Read from jdbc override query' >> ReadFromJdbc( - table_name=table_name, - query=f'select count(*) from {table_name}', - driver_class_name=self.driver_class_name, - jdbc_url=self.jdbc_url, - username=self.username, - password=self.password, - classpath=classpath) - | 'ExtractCount' >> ParDo(ExtractCount())) - assert_that(result, equal_to([ROW_COUNT])) - # Try the same read using the partitioned reader code path. # Outputs should be the same. with TestPipeline() as p:
