[
https://issues.apache.org/jira/browse/BEAM-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991716#comment-15991716
]
Kenneth Knowles edited comment on BEAM-1327 at 5/1/17 11:09 PM:
----------------------------------------------------------------
Noting also that the enum is part of the runner API. At a GBK the
{{TimestampCombiner}} must always be applied to the timestamp after the
{{WindowFn}} has transformed it. This is implemented for all runners and the
Java SDK includes plenty of {{ValidatesRunner}} coverage.
was (Author: kenn):
Noting also that the enum is part of the runner API. At a GBK the
{{TimestampCombiner}} must always be applied to the timestamp after the
{{WindowFn}} has transformed it. This is implemented for all runners.
> Replace OutputTimeFn with enum
> ------------------------------
>
> Key: BEAM-1327
> URL: https://issues.apache.org/jira/browse/BEAM-1327
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Minor
> Labels: backward-incompatible
> Fix For: First stable release
>
>
> The class {{OutputTimeFn}} is overkill for a Fn API crossing. There are only
> three sensible values known: MIN, MAX, EOW. The interface is right for
> implementing these, but the full class is left over from the days when there
> was little cost to shipping new kinds of fns. An enum is concise.
> This can be done "mostly" backwards compatibly with legacy adapters in place,
> but might be less confusing without them.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
