(beam) branch master updated: Set setFailIfPoolExhausted in SessionPoolOptions for SpannerAccessor (#31663)

[yhu]

This is an automated email from the ASF dual-hosted git repository.

yhu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new 53409cca5bb Set setFailIfPoolExhausted in SessionPoolOptions for 
SpannerAccessor (#31663)
53409cca5bb is described below

commit 53409cca5bb89ffd11d73c33bb9db1cfbaf8ba2c
Author: Manit Gupta <manitgu...@google.com>
AuthorDate: Tue Jul 16 22:38:44 2024 +0530

    Set setFailIfPoolExhausted in SessionPoolOptions for SpannerAccessor 
(#31663)
---
 .../java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java     | 5 ++++-
 .../java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessorTest.java | 2 ++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git 
a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java
 
b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java
index dc384450421..943efc9883b 100644
--- 
a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java
+++ 
b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java
@@ -30,6 +30,7 @@ import com.google.cloud.spanner.BatchClient;
 import com.google.cloud.spanner.DatabaseAdminClient;
 import com.google.cloud.spanner.DatabaseClient;
 import com.google.cloud.spanner.DatabaseId;
+import com.google.cloud.spanner.SessionPoolOptions;
 import com.google.cloud.spanner.Spanner;
 import com.google.cloud.spanner.SpannerOptions;
 import com.google.cloud.spanner.v1.stub.SpannerStubSettings;
@@ -229,7 +230,9 @@ public class SpannerAccessor implements AutoCloseable {
     if (credentials != null && credentials.get() != null) {
       builder.setCredentials(credentials.get());
     }
-
+    SessionPoolOptions sessionPoolOptions =
+        SessionPoolOptions.newBuilder().setFailIfPoolExhausted().build();
+    builder.setSessionPoolOption(sessionPoolOptions);
     return builder.build();
   }
 
diff --git 
a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessorTest.java
 
b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessorTest.java
index b80fba31d3a..70105f82053 100644
--- 
a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessorTest.java
+++ 
b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessorTest.java
@@ -18,6 +18,7 @@
 package org.apache.beam.sdk.io.gcp.spanner;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
 import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.verify;
@@ -163,5 +164,6 @@ public class SpannerAccessorTest {
     assertEquals("project", options.getProjectId());
     assertEquals("test-role", options.getDatabaseRole());
     assertEquals(testCredential, options.getCredentials());
+    assertNotNull(options.getSessionPoolOptions());
   }
 }