(beam) branch master updated: Memoize toString() for MetricKey and MetricName (#32379)

[xinyu]

This is an automated email from the ASF dual-hosted git repository.

xinyu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new 64b4aa6fdde Memoize toString() for MetricKey and MetricName (#32379)
64b4aa6fdde is described below

commit 64b4aa6fdde6a65b8157578036374623a47c18c2
Author: Ryan Fu <rf...@linkedin.com>
AuthorDate: Fri Aug 30 17:59:11 2024 -0700

    Memoize toString() for MetricKey and MetricName (#32379)
---
 .../core/src/main/java/org/apache/beam/sdk/metrics/MetricKey.java     | 4 +++-
 .../core/src/main/java/org/apache/beam/sdk/metrics/MetricName.java    | 2 ++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git 
a/sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/MetricKey.java 
b/sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/MetricKey.java
index c092db1e7a8..81e995b39af 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/MetricKey.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/MetricKey.java
@@ -18,6 +18,7 @@
 package org.apache.beam.sdk.metrics;
 
 import com.google.auto.value.AutoValue;
+import com.google.auto.value.extension.memoized.Memoized;
 import java.io.Serializable;
 import org.checkerframework.checker.nullness.qual.Nullable;
 
@@ -32,7 +33,8 @@ public abstract class MetricKey implements Serializable {
   public abstract MetricName metricName();
 
   @Override
-  public final String toString() {
+  @Memoized
+  public String toString() {
     return stepName() + ":" + metricName();
   }
 
diff --git 
a/sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/MetricName.java 
b/sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/MetricName.java
index f452ebeefc4..31607d3330e 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/MetricName.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/MetricName.java
@@ -20,6 +20,7 @@ package org.apache.beam.sdk.metrics;
 import static 
org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Preconditions.checkArgument;
 
 import com.google.auto.value.AutoValue;
+import com.google.auto.value.extension.memoized.Memoized;
 import java.io.Serializable;
 import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Strings;
 
@@ -39,6 +40,7 @@ public abstract class MetricName implements Serializable {
   public abstract String getName();
 
   @Override
+  @Memoized
   public String toString() {
     return getNamespace() + ":" + getName();
   }