GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/2847
[BEAM-818,BEAM-828] Make tempLocation an inaccessible ValueProvider
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
This is my first foray into `ValueProvider` and `PipelineOptions`
excitement. The goal: allow users to access the `tempLocation` that they
specify but make it inaccessible to `PTransform.expand(..)` implementations.
The natural way to do this would be to clone and alter the pipeline
options, something that runners also ought to be doing when they tweak them
like `TestDataflowRunner` does. I am informed this is not possible or feasible
in a short timeframe.
So this is a hack that might not actually work that lets `get()` succeed
but makes `isAccessible()` false. Throwing it out there as a strawman as I
don't see a way to do this correctly given today's constraints.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam runtime-ValueProvider
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2847.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2847
----
commit ebfb87a93448b05d1bdac1e919d2d83d41f00405
Author: Kenneth Knowles <[email protected]>
Date: 2017-05-02T21:36:52Z
Make tempLocation an inaccessible ValueProvider
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
