[
https://issues.apache.org/jira/browse/BEAM-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994443#comment-15994443
]
ASF GitHub Bot commented on BEAM-1941:
--------------------------------------
GitHub user JingsongLi opened a pull request:
https://github.com/apache/beam/pull/2856
[BEAM-1941] Add Source Watermark Metrics
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JingsongLi/beam BEAM-1941-watermark
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2856.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2856
----
commit 283c467847f865f94514e3fab4956bd3ff2631fb
Author: JingsongLi <[email protected]>
Date: 2017-04-24T07:40:53Z
[BEAM-1941] Add Source Watermark Metrics
----
> Add Source Watermark Metrics in Runners
> ---------------------------------------
>
> Key: BEAM-1941
> URL: https://issues.apache.org/jira/browse/BEAM-1941
> Project: Beam
> Issue Type: New Feature
> Components: runner-ideas
> Reporter: Jingsong Lee
> Assignee: Jingsong Lee
>
> The source watermark metrics show the consumer latency of Source.
> It allows the user to know the health of the job, or it can be used to
> monitor and alarm.
> Since each runner is likely already tracking a watermark, another option here
> is to just have the runner report it appropriately, rather than having the
> source report it using metrics. This also addresses the fact that even if the
> source has advanced to 8:00, the runner may still know about buffered
> elements at 7:00, and so not advance the watermark all the way to 8:00.
> [~bchambers]
> Includes:
> 1.Source watermark (`min` amongst all splits):
> type = Gauge, namespace = io, name = source_watermark
> 2.Source watermark per split:
> type = Gauge, namespace = io.splits, name = <split_id>.source_watermark
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
