[
https://issues.apache.org/jira/browse/BEAM-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995581#comment-15995581
]
ASF GitHub Bot commented on BEAM-1902:
--------------------------------------
GitHub user vikkyrk opened a pull request:
https://github.com/apache/beam/pull/2865
[BEAM-1902] Retry on correct error codes for datastoreio
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vikkyrk/incubator-beam ds_retry
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2865.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2865
----
commit bae0fc78f4599b931fd46aa53e00d5356b91d3f5
Author: Vikas Kedigehalli <[email protected]>
Date: 2017-05-03T20:14:20Z
Retry on correct error codes for datastoreio
----
> Datastore IO never retries on errors
> ------------------------------------
>
> Key: BEAM-1902
> URL: https://issues.apache.org/jira/browse/BEAM-1902
> Project: Beam
> Issue Type: Bug
> Components: sdk-py
> Reporter: Ahmet Altay
> Assignee: Vikas Kedigehalli
>
> {{retry_on_rpc_error}} assumes that the {{exception.code}} are HTTP errors
> and tries to retry on error codes {{>= 500}}. However these are rpc errors
> and all are < 500
> Existing rpc error codes:
> https://github.com/googleapis/googleapis/blob/master/google/rpc/code.proto
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
